Re: [PATCH] losetup: Add support for logical block size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 26, 2017 at 04:14:51PM +0200, Stanislav Brabec wrote:
>  include/loopdev.h   |  4 ++++
>  lib/loopdev.c       | 46 ++++++++++++++++++++++++++++++++++++++++++++
>  sys-utils/losetup.8 |  3 +++
>  sys-utils/losetup.c | 55 ++++++++++++++++++++++++++++++++++++++++-------------
>  4 files changed, 95 insertions(+), 13 deletions(-)

Merged (with fixed get() function).

I'm not sure about the "BLOCKSIZE" column name. For lsblk we use
"LOG-SEC" (and "PHY-SEC"), it seems more explicit and shorter. What
about to use the same column name for losetup too? From my point of
view "BLOCKSIZE" is too vague it would be nice to minimize differences
in terminology used by the tools (losetup and lsblk).

Maybe we can also rename "--logical-blocksize" to "--log-sector".

Comments?

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux