Re: [V2 0/4] hwclock: remove date(1)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 28, 2017 at 10:23:39AM -0500, J William Piggott wrote:
> My impression is that the original parse_datetime() is stable. It seems
> like most of the changes now involve parse_datetime2() to expand
> capabilities. I was using the new api only for the debug output; I
> thought if changes were ever needed in the parser it might be helpful.
> Since that may be unlikely, and since you don't like the debugging,
> parse_datetime2() along with all of its extensions can be removed.

Fortunately, this stuff is easy to test, so we can create regression
tests for all the possible formats to be sure we do not introduce any
regression.

> > I guess it will be possible to move it to lib/parse-datetime.c and use
> > it on another places in util-linux (instead of our minimalistic
> > parse_datetime()), right?
> 
> Sure, I think a name change to avoid confusion with gnulib would be
> good. Maybe just parse_date.c?

Sounds, good.

> I will work on these changes Karel.

OK.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux