Re: [PATCH] setterm: fix bitfield warning [smatch]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Feb 25, 2017 at 05:35:17PM +0000, Sami Kerola wrote:
> term-utils/setterm.c:179:27: warning: dubious bitfield without explicit
> `signed' or `unsigned'
> 
> Signed-off-by: Sami Kerola <kerolasa@xxxxxx>
> ---
>  term-utils/setterm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/term-utils/setterm.c b/term-utils/setterm.c
> index 1cf59957b..8e969c2b3 100644
> --- a/term-utils/setterm.c
> +++ b/term-utils/setterm.c
> @@ -176,7 +176,7 @@ struct setterm_control {
>  	int opt_rt_len;		/* regular tab length */
>  	int opt_tb_array[TABS_MAX + 1];	/* array for tab list */
>  	/* colors */
> -	int opt_fo_color:4, opt_ba_color:4, opt_ul_color:4, opt_hb_color:4;
> +	unsigned int opt_fo_color:4, opt_ba_color:4, opt_ul_color:4, opt_hb_color:4;

Often and stupid bug, good catch.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux