Re: libmount python bindings and header includes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 12, 2016 at 01:46:53PM -0400, Mike Frysinger wrote:
> i'm currently seeing these build warnings:
> libmount/python/fs.c:110:40: warning: implicit declaration of function 'major'
> libmount/python/fs.c:111:7: warning: implicit declaration of function 'minor'
> 
> this is handled for most of the code in include/c.h:
> #ifdef HAVE_SYS_SYSMACROS_H
> # include <sys/sysmacros.h>     /* for major, minor */
> #endif
> 
> but the python code doesn't include that header.  i'm not sure what the
> preference is here (make the python code pull in that header or just copy
> over the sysmacros.h logic), so i'm skipping writing a patch.

Our c.h is so wonderful that it's expected everywhere :) Fixed.

Thanks!
    Karel


-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux