Mike Frysinger wrote:
On 05 May 2015 11:37, Pádraig Brady wrote:
On 04/05/15 04:51, Mike Frysinger wrote:
From: Mike Frysinger <vapier@xxxxxxxxxxxx>
The symlink generation tries to write to the sys-utils/ subdir but does
not make sure that dir exists. This can sometimes lead to parallel build
failures when building out-of-tree
$(SETARCH_MAN_LINKS):
+ $(AM_V_at) test -d $(dir $@) || mkdir -p $(dir $@)
$(AM_V_GEN)echo ".so man8/setarch.8" > $@
install-exec-hook-setarch:
The `test -d ... ||` bit is racy and redundant I think
i noticed that, but i didn't bother fixing it -- i just copied & pasted from an
earlier fix in this project which used the same exact line
note: it's really only racy if mkdir itself fails internally, and i'm kind of
the opinion that mkdir itself should be handling this
-mike
Why do the test at all? Why not just a simple `mkdir -p $(dir $@)` ?
-- Bruce
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
