Re: [PATCH] build-sys: fix parallel builds w/setarch links

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/05/15 04:51, Mike Frysinger wrote:
> From: Mike Frysinger <vapier@xxxxxxxxxxxx>
> 
> The symlink generation tries to write to the sys-utils/ subdir but does
> not make sure that dir exists.  This can sometimes lead to parallel build
> failures when building out-of-tree

>  $(SETARCH_MAN_LINKS):
> +	$(AM_V_at) test -d $(dir $@) || mkdir -p $(dir $@)
>  	$(AM_V_GEN)echo ".so man8/setarch.8" > $@
>  
>  install-exec-hook-setarch:

The `test -d ... ||` bit is racy and redundant I think

cheers,
Pádraig

--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux