Re: [PATCH 16/16] logger: fix -i argument parsing regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 22 Feb 2015, Benno Schulenberg wrote:

> On Sun, Feb 22, 2015, at 15:41, Sami Kerola wrote:
> > Reviewed-by: Benno Schulenberg <benno@xxxxxxxxxxx>
> 
> Please use my justemail address (the current one) here instead.
> The vertaalt one I use just for translations.
> 
> > +.BR \-i
> 
> s/BR/B/    (since there is just one argument)
> 
> > +.BR "\-\-id" [ = \fIid ]
> 
> s/= /=/    (to fix my own mistake)
> 
> > -	fputs(_(" -i, --id[=<id>]          log <id> (default is PID)\n"), out);
> > +	fputs(_(" -i                       log logger command PID\n"), out);
> 
> Better: "log the logger command's PID" -- there is room enough to
> avoid telegram style.

Nalime Benno,

> > +	fputs(_("     --id[=<id>]          log <id> (default is PID)\n"), out);
> 
> Better: "log the given <id>, or otherwise the PID"

Here is updated version of the change.

https://github.com/kerolasa/lelux-utiliteetit/commit/7dbe2082a9d87316d7aed7d1c8a7f94a8a80b1f0

-- 
Sami Kerola
http://www.iki.fi/kerolasa/
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux