Re: [PATCH 16/16] logger: fix -i argument parsing regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 22, 2015, at 15:41, Sami Kerola wrote:
> Reviewed-by: Benno Schulenberg <benno@xxxxxxxxxxx>

Please use my justemail address (the current one) here instead.
The vertaalt one I use just for translations.

> +.BR \-i

s/BR/B/    (since there is just one argument)

> +.BR "\-\-id" [ = \fIid ]

s/= /=/    (to fix my own mistake)

> -	fputs(_(" -i, --id[=<id>]          log <id> (default is PID)\n"), out);
> +	fputs(_(" -i                       log logger command PID\n"), out);

Better: "log the logger command's PID" -- there is room enough to
avoid telegram style.

> +	fputs(_("     --id[=<id>]          log <id> (default is PID)\n"), out);

Better: "log the given <id>, or otherwise the PID"

Benno

-- 
http://www.fastmail.com - Access all of your messages and folders
                          wherever you are

--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux