On Mon, Feb 16, 2015 at 12:00:53AM -0500, Mike Frysinger wrote:
> On 28 Dec 2014 20:30, Phillip Susi wrote:
> > --- libsmartcols/src/table_print.c 2014-12-24 23:59:55.780110296 +0200
> > +++ libsmartcols/src/table_print.c 2014-12-28 22:45:20.347285226 +0200
> >
> > + assert(ln);
> > + assert(buf);
>
> general note: libraries should never assert/abort/exit.
what about segfault?
We use assert to detect fatal internal library bugs, for mistakes in
applications (e.g. incomplete arguments) it returns -EINVAL.
Its' possible to remove CONFIG_LIBSMARTCOLS_ASSERT from smartcolsP.h,
but I don't think the library is already well tested.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
