On Wednesday 03 September 2014, Adam Sampson wrote: > On Wed, Sep 03, 2014 at 12:54:27PM +0200, Karel Zak wrote: > > - make ipcs limit calculations work when numbers are large > > That change isn't right -- it reverses the sense of the test, making > the testcase fail on 3.16 again. Patch attached. Your patch seems to be correct except that it should be "<=" instead of "<": if [ $(bc <<<"2^64 / $PAGE_SIZE <= $SHMALL") -eq 1 ]; then to have the same (correct) behavior like before 3a9ec12d. The mistake in 3a9ec12d happened probably because Sami tried to avoid "greater than" relations. but for my brain this line would be still more easy to read: if [ $(bc <<<"$SHMALL >= 2^64 / $PAGE_SIZE") -eq 1 ]; then Maybe that's why me and others have not noticed the mistake when reviewing that patch. cu, Rudi -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
