On 24 July 2014 10:55, Karel Zak <kzak@xxxxxxxxxx> wrote:
> On Tue, Jul 22, 2014 at 11:00:56PM +0100, Sami Kerola wrote:
>> struct logger_ctl {
>> @@ -82,6 +85,9 @@ struct logger_ctl {
>> int logflags;
>> int pri;
>> char *tag;
>> + unsigned int rfc5424_time:1,
>> + rfc5424_tq:1,
>
> what does it mean "_tq"? It's always good idea use comments for flags
> and struct members :-)
Comments added.
https://github.com/kerolasa/lelux-utiliteetit/commit/499505cbc97e9047afb982bc66129a94b181b16e#diff-f68064e0e43fa893a5676182f1572882R92
>> + fputs(_(" --rfc3164 use the BSD syslog protocol\n"), out);
>
> "use obsolete BSD syslog protocol"
> ^^^^^^^
The BSD protocol is marked obsolete.
>> + parse_rfc5424(&ctl, optarg);
>
> parse_rfc5424_flags()
The '_flags' is added to function name.
https://github.com/kerolasa/lelux-utiliteetit/commit/499505cbc97e9047afb982bc66129a94b181b16e#diff-f68064e0e43fa893a5676182f1572882R370
--
Sami Kerola
http://www.iki.fi/kerolasa/
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
