Re: [PATCH 07/10] logger: add rfc5424 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 22, 2014 at 11:00:56PM +0100, Sami Kerola wrote:
>  struct logger_ctl {
> @@ -82,6 +85,9 @@ struct logger_ctl {
>  	int logflags;
>  	int pri;
>  	char *tag;
> +	unsigned int	rfc5424_time:1,
> +			rfc5424_tq:1,

 what does it mean "_tq"? It's always good idea use comments for flags
 and struct members :-)

> +	fputs(_("     --rfc3164         use the BSD syslog protocol\n"), out);

 "use obsolete BSD syslog protocol"
      ^^^^^^^

> +				parse_rfc5424(&ctl, optarg);

   parse_rfc5424_flags()

 or so...

    Karel


-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux