Hi! On Sun, 08 Jun 2014, Dave Reisner wrote: > On Sun, Jun 08, 2014 at 03:32:48PM +0200, Ruediger Meier wrote: > > From: Ruediger Meier <ruediger.meier@xxxxxxxxxxx> > > > > Reported-by: Tobias Klausmann <klausman@xxxxxxxxxxxxxxx> > > Signed-off-by: Ruediger Meier <ruediger.meier@xxxxxxxxxxx> > > --- > > libfdisk/src/bsd.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libfdisk/src/bsd.c b/libfdisk/src/bsd.c > > index a81afd2..df0fc13 100644 > > --- a/libfdisk/src/bsd.c > > +++ b/libfdisk/src/bsd.c > > @@ -773,8 +773,10 @@ static int bsd_translate_fstype (int linux_type) > > case 0x06: /* DOS 16-bit >=32M */ > > case 0xe1: /* DOS access */ > > case 0xe3: /* DOS R/O */ > > +#if !defined (__alpha__) > > case 0xf2: /* DOS secondary */ > > return BSD_FS_MSDOS; > > +#endif > > What would be the harm on defining this for platforms which don't > include it? Why is a partition type excluded from this architecture? For some reason, 8 has two meanings: BSD_FS_MSDOS almost everywhere, but BSD_FS_EXT2 on Alpha. I'm not well-versed enough in the code to be sure whether the case above (0xf2) is a "can't happen" on Alpha). It may be that the better approach would be to return an error condition or something entirely different, including BSD_FS_EXT2. For the Alphas I have access to, the patch from Ruediger works just fine. Regards, Tobias -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
