On Mon, Sep 09, 2013 at 05:28:57PM +0200, Gabriel de Perthuis wrote: > It's correct insofar as current consumers expect it, and it's better > for error reporting. The patches took care of my other objections, > so you can keep the crc check and go with what's on > https://github.com/g2p/util-linux/commits > (the csum patches I sent + Rolf's patch + a patch that depends on both). Merged with some changes - not added blkid_probe_is_badcsum() the info about bad csum is exported by SBBADCSUM=1 variable, you have to use for example: if (blkid_probe_has_value(pr, "SBBADCSUM")).... - the usage type is BLKID_USAGE_OTHER rather than "raid" (we have some special exceptions and tests for raids that are unnecessary for bcache) I have also added the test images from Rolf to util-linux test suite. $ blkid -o udev -p tests/output/blkid/images-fs/bcache-C.img ID_FS_UUID=7a343627-ac87-4bf0-b76f-46067cbc9b8c ID_FS_UUID_ENC=7a343627-ac87-4bf0-b76f-46067cbc9b8c ID_FS_TYPE=bcache ID_FS_USAGE=other Thanks! Karel -- Karel Zak <kzak@xxxxxxxxxx> http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
