I believe these are finally ready for merging. Freshly rebased. Patches 3 and 4 could be merged, but I think it's a little cleaner to read/review with the changes seperate. Version 3 of the patches, incorporating all changes suggested to this point. Only changes from v2 are fixing the error string and dropping initgroups in patch 3/4. Tested: Building and running both with and without libuser support enabled, with a valid password, invalid password, and running as root. Cody Maloney (4): chsh-chfn: Add flag for enabling/disabling libuser support. chsh-chfn: Move pam auth to its own function, factoring out common code chsh: Add libuser support chfn: Add libuser support configure.ac | 17 ++++++++++ login-utils/Makemodule.am | 10 ++++++ login-utils/auth.c | 47 ++++++++++++++++++++++++++++ login-utils/auth.h | 13 ++++++++ login-utils/chfn.c | 58 +++++++++++++++------------------- login-utils/chsh.c | 53 ++++++++++++++----------------- login-utils/libuser.c | 80 +++++++++++++++++++++++++++++++++++++++++++++++ login-utils/libuser.h | 14 +++++++++ 8 files changed, 229 insertions(+), 63 deletions(-) create mode 100644 login-utils/auth.c create mode 100644 login-utils/auth.h create mode 100644 login-utils/libuser.c create mode 100644 login-utils/libuser.h -- 1.8.1 -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html