Re: [PATCH 1/3] a pointer should not be compared to zero [coccinelle]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/02/13 12:01, Karel Zak wrote:
> On Sat, Feb 02, 2013 at 11:58:05PM +0100, Ángel González wrote:
>> On 30/01/13 21:33, Sami Kerola wrote "a pointer should not be compared
>> to zero":
>>> Signed-off-by: Sami Kerola <kerolasa@xxxxxx>
> 
>  Applied, thanks.
> 
>> Why not? It is perfectly legal.
>> See http://www.c-faq.com/null/null2.html
> 
>  It's usually legal from compiler or C standard point of view, but
>  it's horrible coding style manner.

I agree it's nicer, but if it's just for coding style I would have
expected a commit message about that, not "should not be compared".


>  For example:
>     http://lwn.net/Articles/93574/

Funny Linus remarks :)

--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux