On Tue, Jul 26, 2011 at 16:22, Karel Zak <kzak@xxxxxxxxxx> wrote: > On Tue, Jul 26, 2011 at 12:42:46AM +0200, Sami Kerola wrote: >> are available in the git repository at: >> https://github.com/kerolasa/lelux-utiliteetit hwclock >> hwclock: include-what-you-use header check > > Hmm.. I see something completely different in the patch: > > Showing 5 changed files with 171 additions and 216 deletions. > > it seems like "use libc error facilities". Do'h. One of my rebase fix something etc had lead to accidental squash. The commit is split to two as it was meant to be. >> hwclock: remove inb & outb functions > > Are you really sure? I think it depends on the header files, for > example it seems GNU Hurd reads information from cmos > > http://www.spinics.net/lists/util-linux-ng/msg04179.html > > and we already talked about it: > > http://www.spinics.net/lists/util-linux-ng/index.html#04673 I did not study history well enough before proposing this. The commit is thrown away. >> hwclock: fix compiler warnings > > This is wrong for __alpha__ code where the variables are used. > > Move the comment before the function and the begin of the function to > the #ifndef __alpha_ block, then you can use __unused__ for non-aplha > only. I changed the commit to have complete functions in precompiler if statements. To me it looks most readable way of doing what you seem to mean. >> hwclock: move long options away from global scope > > But the enum {} does not have to be in the main(). Moved to the beginning of the file. All is pushed to my repo with force. Let me know if there is something other that needs nudging. -- Sami Kerola http://www.iki.fi/kerolasa/ -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
