Re: [PATCH 5/7] Better support of virtual console

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 10, 2011 at 05:34:30PM +0200, Dr. Werner Fink wrote:
> Better support of virtual console due support of UTF-8 login names
> provided by e.g. LDAP.  Set default size 24/80 on serial modem lines
> if not found by the kernel.

 Applied, but...

> @@ -1095,92 +1118,134 @@ static char *get_logname(struct options *op, struct termios *tp, struct chardata
[...]
> -			/* Do BREAK handling elsewhere. */
> -			if ((c == 0) && op->numspeed > 1)
> -				return EXIT_SUCCESS;
                
 the original get_logname() returns zero

>  			/* Do erase, kill and end-of-line processing. */
>  			switch (ascval) {
> +			case 0:
> +				*bp = 0;
> +				if (op->numspeed > 1)
> +					return logname;
> +				break;

 your new version does not return zero. The code in main() checks for
 the zero to call next_speed().

 It seems like a bug, right?

    Karel


-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux