Re: [PATCH 4/7] Check virtual console for UTF-8 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 09, 2011 at 03:52:37PM +0200, Werner Fink wrote:
> Check out a virtual console line for UTF-8 support, also skip
> modem specific setups on a virtual console line.

 Applied.
 
> @@ -348,18 +354,21 @@ int main(int argc, char **argv)
>  		debug("reading login name\n");
>  		while ((logname =
>  			get_logname(&options, &termios, &chardata)) == 0)
> -			next_speed(&options, &termios);
> +			if ((options.flags & F_VCONSOLE) == 0)
> +				next_speed(&options, &termios);
>  	}

 Does it make sense to use while() for console if next_speed() is not
 called? I can imagine infinite loop here :-(
 
 Shouldn't be:

   if (options.flags & F_VCONSOLE))
        logname = get_logname(&options, &termios, &chardata);
   else
  		while ((logname =
  			get_logname(&options, &termios, &chardata)) == 0)
			next_speed(&options, &termios);



    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux