Re: [PATCH 1/3] agetty.c: further scrubbing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 26, 2011 at 09:28:59PM +0200, Sami Kerola wrote:
>  term-utils/agetty.c | 1100 ++++++++++++++++++++++++++-------------------------
>  1 files changed, 555 insertions(+), 545 deletions(-)

 Applied, thanks ...some details:

> +#  ifdef HOST_NAME_MAX
> +#    define MAXHOSTNAMELEN HOST_NAME_MAX
> +#  else
> +#    define MAXHOSTNAMELEN 64
> +#  endif			/* HOST_NAME_MAX */
> +#endif				/* MAXHOSTNAMELEN */

 Note that the comment for #endif is unnecessary for really small blocks.

> -	termio_init(&termios, &options);
> +	termio_init(&options, &termios);

 This does not look like a coding style change :-)

> -#endif /* DO_DEVFS_FIDDLING */
> +#endif				/* DO_DEVFS_FIDDLING */

 This is odd change. The old version is more readable.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux