On Wed, Apr 06, 2011 at 09:31:00PM +0200, Sami Kerola wrote:
> The TMPDIR environment is preferred over _PATH_TMP in which a
> file is created that is ultimately sent to terminals. This patch
> will also fix compiler warnings and removes magical numbers,
> which has not explanation.
>
> Signed-off-by: Sami Kerola <kerolasa@xxxxxx>
> ---
> term-utils/wall.c | 74 +++++++++++++++++++++++++++++++++-------------------
> 1 files changed, 47 insertions(+), 27 deletions(-)
Applied, thanks.
> + tmpname = xmalloc(PATH_MAX);
I think you can use
char tmpname[PATH_MAX];
next time.
> - errx(EXIT_FAILURE, _("can't read %s."), fname);
> + err(EXIT_FAILURE, _("cannot open file %s."), fname);
The '.' is unwanted here ;-)
> mbufsize = sbuf.st_size;
> + memcpy(mainmbufsize, &mbufsize, sizeof(size_t));
Why not
*mainmbufsize = (size_t) sbuf.st_size;
the memcpy seems like a really strange solution here. I have removed
this from the code.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
