Re: [PATCH 3/5] script: support for long options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 20, 2011 at 01:21:15PM +0100, Sami Kerola wrote:
> Signed-off-by: Sami Kerola <kerolasa@xxxxxx>
> ---
>  misc-utils/script.c |   53 +++++++++++++++++++++++++++++++++++++++-----------
>  1 files changed, 41 insertions(+), 12 deletions(-)

 Applied with a small change, thanks. 

> -		if (!strcmp(argv[1], "-V") || !strcmp(argv[1], "--version")) {
                         ^^^^^^^^^
> -			printf(_("%s (%s)\n"),
> -			       program_invocation_short_name, PACKAGE_STRING);
> -			return 0;
> -		}

[...]

> +		case 'v':
         ^^^^^^^^
> +			printf(_("%s (%s)\n"), "script", PACKAGE_STRING);
> +			exit(EXIT_SUCCESS);
> +			break;

 I think -V is better and backwardly compatible.

    Karel


-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux