Re: [PATCH 2/5] script: use libc error printing facilities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 20, 2011 at 01:21:14PM +0100, Sami Kerola wrote:
> Signed-off-by: Sami Kerola <kerolasa@xxxxxx>
> ---
>  misc-utils/script.c |   52 ++++++++++++++++++--------------------------------
>  1 files changed, 19 insertions(+), 33 deletions(-)

 Applied, thanks.

>  	if ((fscript = fopen(fname, aflg ? "a" : "w")) == NULL) {
> -		perror(fname);
> +		warn("%s", fname);

        warn(_("open failed: %s", fname));

 Please, use something more verbose next time -- ideally something
 already used in another program (see po/util-linux.pot for examples).
 
   Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux