Le 20 juil. 2010 à 21:01, Mike Frysinger a écrit : > On Tuesday, July 20, 2010 13:11:34 François Revol wrote: >> do not use the program_invocation_short_name GNU extension but just argv[0] >> instead, and pass it along to usage() fonctions. > > those two things are not equivalent. if you want to extend util-linux to > other OSs, you really need to do so without breaking the primary intended OS: > Linux. have the configure script check for program_invocation_short_name and > then create a helper function/macro to hide the difference. you should also > trim down argv[0] in the fallback case so that it is actually the short name. Hmm seems I was too short in looking up, I just noticed program_invocation_name as being equivalent to argv[0]... http://linux.die.net/man/3/program_invocation_short_name >> Avoid a name clash with BSD strmode() call. >> Avoid using non-standard ulong type. >> Use configure checks for struct shminfo before using it. > > please split patches up into logical pieces instead of merging unrelated > changes into one. Well sorry but I made the patches after fixing the thing, and it happened to have 2 things in the same file. François.-- To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
