Re: [PATCH 5/8] portability: do not use program_invocation_short_name...

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, July 20, 2010 13:11:34 François Revol wrote:
> do not use the program_invocation_short_name GNU extension but just argv[0]
> instead, and pass it along to usage() fonctions.

those two things are not equivalent.  if you want to extend util-linux to 
other OSs, you really need to do so without breaking the primary intended OS: 
Linux.  have the configure script check for program_invocation_short_name and 
then create a helper function/macro to hide the difference.  you should also 
trim down argv[0] in the fallback case so that it is actually the short name.

> Avoid a name clash with BSD strmode() call.
> Avoid using non-standard ulong type.
> Use configure checks for struct shminfo before using it.

please split patches up into logical pieces instead of merging unrelated 
changes into one.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux