Re: [PATCH] umount: do not sync() as the kernel does it by itself

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 21, 2010 at 02:18:31PM +0200, Petr Uzel wrote:
> On Fri, May 21, 2010 at 08:00:09AM -0400, Christoph Hellwig wrote:
> > On Fri, May 21, 2010 at 01:55:17PM +0200, Petr Uzel wrote:
> > > SUSE-based distributions have the following patch for some time. More
> > > info here: https://bugzilla.novell.com/show_bug.cgi?id=447036
> > > 
> > > From the Novell bugzilla:
> > > <quote>
> > > > I cannot see any justification for that sync call at all so I'd
> > > > probably just remove it.  Your
> > > > patch is possibly safer so maybe it should be used as is.
> > > </quote>
> > > 
> > > So, does anybody know why/if the sync() is actually needed?
> > 
> > It's not needed.  The kernel performs a sync by itself.
> 
> Thanks, Christoph.
> 
> 
> Signed-off-by: Petr Uzel <petr.uzel@xxxxxxx>
> ---
>  mount/umount.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)

 Applied, thanks.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux