On Fri, May 21, 2010 at 08:00:09AM -0400, Christoph Hellwig wrote: > On Fri, May 21, 2010 at 01:55:17PM +0200, Petr Uzel wrote: > > SUSE-based distributions have the following patch for some time. More > > info here: https://bugzilla.novell.com/show_bug.cgi?id=447036 > > > > From the Novell bugzilla: > > <quote> > > > I cannot see any justification for that sync call at all so I'd > > > probably just remove it. Your > > > patch is possibly safer so maybe it should be used as is. > > </quote> > > > > So, does anybody know why/if the sync() is actually needed? > > It's not needed. The kernel performs a sync by itself. Thanks, Christoph. Signed-off-by: Petr Uzel <petr.uzel@xxxxxxx> --- mount/umount.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/mount/umount.c b/mount/umount.c index 6786ac5..75507b7 100644 --- a/mount/umount.c +++ b/mount/umount.c @@ -379,7 +379,6 @@ umount_all (char *types, char *test_opts) { } } - sync (); return errors; } -- 1.6.4.2 Petr -- Petr Uzel IRC: ptr_uzl @ freenode
Attachment:
pgpDA6wiGBRXJ.pgp
Description: PGP signature
