On Sat, Jan 16, 2010 at 05:15:18PM +0100, Kay Sievers wrote: > On Fri, Jan 15, 2010 at 22:43, Karel Zak <kzak@xxxxxxxxxx> wrote: > > I understand your point of view, and I have no problem to add to > > blkid all necessary functionality for compatibility with your > > point of view. But I have doubts that udev will use it. > > > > All this was discussed 2 (?) years ago. The current blkid behavior > > is based on the results from the discussion. > > > > I'll > > - add an option to allow run blkid in less paranoid mode (return > > the first detected superblock) > > We can definitely not use it. Filesystem-probing and auto-mounting is Expected answer :-) > not meant to return wild guesses, and risk to destroy data by careless > and dumb optimizations. I found something interesting in the old vol_id now. The old code does not apply the paranoid probing method (check for all filesystems) to devices smaller than 1.4MB: /* * We probe for all known filesystems to find conflicting signatures. [...] * We do not want to read that many bytes from probed * floppies, skip volumes smaller than a usual floppy disk. */ I think we can use the same logic in blkid. Comment? Karel -- Karel Zak <kzak@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html