On Tue, Oct 27, 2009 at 12:21:18PM +0200, Bastian Friedrich wrote:
> Hi,
>
> I obviously forgot to point out the fact that the supplied patch only detects
> devices with internal meta data.
>
> External meta data may be located on theoretically arbitrary locations on
> disks (every chunk of 128M may be used for meta data). One could arguably try
> to scan the first sector to probe it for the super block; the current code
> does not.
>
> I am personally not using external meta data; if requested, I can still try to
> create a probe for the first meta data block though.
>
> On Monday 26 October 2009, Karel Zak wrote:
> > > drbd may be used in "stacked" environments, such as LVM-on-DRBD-on-LVM.
> > > Due to
> >
> > Well, does it mean that all (FS, LVM,...) signatures on physical
> > device in the "stacked" environment are on valid offsets? I don't
> > think so.
>
> As Lars pointed out, signatures at the beginning of the device will remain
> intact.
>
> > > that, flag BLKID_IDINFO_TOLERANT is required; also, the position of the
> > > info struct in idinfos seems to be critical.
> >
> > It seems we can think about DRBD as about a raid device. So it should
> > be enough to replace the "tolerant" flag with "raid" flag and probe
> > for DRBD after real raids and before LVM.
>
> Looks good (and seems to do the job for me).
>
> I'd be glad to supply a new patch if required.
That won't be necessary. I'll do this small change before commit.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
