Re: [PATCH] DRBD support for blkid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I obviously forgot to point out the fact that the supplied patch only detects 
devices with internal meta data.

External meta data may be located on theoretically arbitrary locations on 
disks (every chunk of 128M may be used for meta data). One could arguably try 
to scan the first sector to probe it for the super block; the current code 
does not.

I am personally not using external meta data; if requested, I can still try to 
create a probe for the first meta data block though.

On Monday 26 October 2009, Karel Zak wrote:
> > drbd may be used in "stacked" environments, such as LVM-on-DRBD-on-LVM.
> > Due to
>
> Well, does it mean that all (FS, LVM,...) signatures on physical
> device in the "stacked" environment are on valid offsets? I don't
> think so.

As Lars pointed out, signatures at the beginning of the device will remain 
intact.

> > that, flag BLKID_IDINFO_TOLERANT is required; also, the position of the
> > info struct in idinfos seems to be critical.
>
> It seems we can think about DRBD as about a raid device. So it should
> be enough to replace the "tolerant" flag with "raid" flag and probe
> for DRBD after real raids and before LVM.

Looks good (and seems to do the job for me).

I'd be glad to supply a new patch if required.

Thx
   Bastian

-- 
Collax GmbH . Basler Str. 115a . 79115 Freiburg . Germany
p: +49 (0) 89-990 157-28	www.collax.com

Geschäftsführer: Boris Nalbach
AG München HRB 158898 . Ust.-IdNr: DE 814464942
\ Don't rush me. I get paid by the hour.
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux