On Thu, Mar 05, 2009 at 11:55:50AM +0000, Hugh Dickins wrote:
> On Tue, 3 Mar 2009, Karel Zak wrote:
>
> > > On Thu, Jan 22, 2009 at 04:46:57PM +0000, Hugh Dickins wrote:
> > > Though your swapon may mkswap for suspend reasons: hmm, wouldn't it
> > > do very much better just to rewrite the swap signature, than exec
> > > mkswap - maybe nobody ever uses the badpages list, but it really
> > > should be respected.
> >
> > CC: Hugh Dickins <hugh@xxxxxxxxxxx>
> > Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>
> > ---
>
> Thanks a lot, Karel: this is a great improvement - seeing it
> implemented makes me feel all the more strongly that it was needed.
>
> One small point: if the lseek or write in swap_rewrite_signature()
> were to fail (neither seems likely), then there's no error message
> to the user that it failed.
Good point. Fixed. Thanks.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
