On Thu, Mar 05, 2009 at 12:19:10PM +0000, Hugh Dickins wrote:
> On Tue, 3 Mar 2009, Karel Zak wrote:
> > + warn(_("%s: swap format pagesize does not match. "
> > + "(may try --fixpgsz to reinitialize)"),
>
> "(may try ...)" sounds to me a bit as if it might choose to do that itself.
> I think "Use --fixpgsz to reinitialize it." sounds better.
>
> I'm out of the habit of userspace programming, so unfamiliar with warn()
> and warnx(), but wondering if the use of warn() here is correct - doesn't
> it append an errno message, yet errno won't be relevant?
Ah, you're right. Fixed. Thanks for review.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
