Re: [PATCH] hwclock: add --systz option to set system clock from itself

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2009-03-04 at 21:58 +0100, Karel Zak wrote:

> On Wed, Mar 04, 2009 at 08:45:53PM +0000, Scott James Remnant wrote:
> > On Wed, 2009-03-04 at 20:43 +0100, Karel Zak wrote:
> > 
> > > > -    if (!noadjfile && (adjust || set || systohc || (!utc && !local_opt))) {
> > > > +    if (!noadjfile && (adjust || set || systohc || systz || (!utc && !local_opt))) {
> > > >        rc = read_adjtime(&adjtime);
> > >  
> > >  Should be:
> > > 
> > >    if (!noadjfile && (adjust || set || systohc || (!utc && !local_opt))) {
> > > 
> > >  it means: read the file when --{utc,local} are not given.
> > > 
> > >  but don't worry. I'll fix it before commit. Thanks.
> > > 
> > Don't you want to read the file when --systz is given?  It does write it
> 
>  I want to read the file when --utc or --local is not given.
> 
>   hwclock --systz         = read the file (because we need UTC/LOCAL setting)
>   hwclock --systz --utc   = don't read the file
> 
Ah, I see what you mean now.  That makes perfect sense.

> > out again, after all.
> 
>  do you mean save_adjtime()? It does not write the file when
>  adjtime.dirty = FALSE.
> 
Ah, of course.

Scott
-- 
Scott James Remnant
scott@xxxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux