On Wed, Mar 04, 2009 at 06:01:09PM +0000, Scott James Remnant wrote:
> On Tue, 2009-03-03 at 10:25 +0100, Karel Zak wrote:
>
> > > Should I rework the patch to do this?
> >
> > Yes, please. Thanks!
> >
> Tested and attached.
>
> btw. I'm correct in believing that hwclock doesn't actually use the
> values in /etc/adjtime unless --adjust is given, right?
That depends.. it uses UTC/LOCAL from the file when you not specify
--{utc,local} options. The rest of values (adjust factor, ...) unless
--adjust is given, but the adjust values are updated when --{set,systohc}
is given. The update also depends on last adjtime update
(see adjust_drift_factor(). Spaghetti code... :-)
> - if (!noadjfile && (adjust || set || systohc || (!utc && !local_opt))) {
> + if (!noadjfile && (adjust || set || systohc || systz || (!utc && !local_opt))) {
> rc = read_adjtime(&adjtime);
Should be:
if (!noadjfile && (adjust || set || systohc || (!utc && !local_opt))) {
it means: read the file when --{utc,local} are not given.
but don't worry. I'll fix it before commit. Thanks.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
