Pádraig Brady wrote: > Samuel Thibault wrote: >> Pádraig Brady, le Sun 01 Mar 2009 23:38:08 +0000, a écrit : >>>> Also worth noting is that if/when someone chooses to uncomment code in >>>> cal.c, the day will be off by one, because in the locale data Sunday=1, >>>> Monday=2, while cal.c assumes the C-style Sunday=0, Monday=1. >>> If you could send a patch that was tested it would help in making this change. >> my 2c: >> >> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=472355 >> [cal] should use locale's _NL_TIME_WEEK_1STDAY to know the first day of a week >> contains a patch >> http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=39;filename=patch;att=1;bug=472355 >> which I'd gladly see you get inspired from. > > Thanks Samuel! > Proposed patch attached. Hi Ulrich, I recently added a change to the `cal` command to display a calendar with the first day of the week determined from the locale data. However upon reviewing the pertinent data for the en_GB locale: http://sourceware.org/cgi-bin/cvsweb.cgi/libc/localedata/locales/en_GB?cvsroot=glibc I noticed that week_1stday=19971201 and first_weekday=2. That change done 5 months ago corresponds to Tuesday which is obviously wrong. Do you intend first_weekday=1 always correspond to Sunday now, or was this just an unintended checkin? Did you perhaps assume that week_1stday was 19971130, and if so may other locales be affected by that assumption? cheers, Pádraig. p.s. The en_IE locale should match en_GB for these variables. I noticed that debian have patched en_IE to monday but not propagated those changes back? -- To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
