Re: cal: First day of the week

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Lauri Nurmi wrote:
> Hello.
> 
> The 'cal' utility assumes that week begins on Sunday, if not explicitly
> told otherwise with the -m option.  In cal.c, there is code for
> determining the first day of week from locale, but the code is commented
> out.  I think it is about time to uncomment this piece of code and start
> obeying the locale.
> 
> The piece of code is accompanied by a lengthy philosophical paragraph
> about first day of week, which I'll quote and comment here:
> 

[sensible arguments for a variable first day of week elided]

> ---
> 
> It is worth mentioning that Debian uses some other cal implementation,
> which does determine the first day of week from locale.

The main worry I'd have with a variable first day of week is that
scripts may depend on sunday being the first. However the fact
that Debian's cal is variable in this regard hugely alleviates that concern.
So I think this is a good idea.

> Also worth noting is that if/when someone chooses to uncomment code in
> cal.c, the day will be off by one, because in the locale data Sunday=1,
> Monday=2, while cal.c assumes the C-style Sunday=0, Monday=1.

If you could send a patch that was tested it would help in making this change.

cheers,
Pádraig.
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux