Karel Zak schrieb: > On Sat, Jan 17, 2009 at 02:38:32AM +0100, Jakob Unterwurzacher wrote: >> Allow users to set the "none" class on processes. Using the > > You're right that the SYS_ioprio_get syscall differentiate between > "none" (0) and "best-effort" (2) classes, but in all documentation > are three classes only (and de facto we have three classes only). > > I'm not sure with your previous patch to ionice.1 man page. Would be > better to describe the "none" as a subset of BE rather than any > separate class? I think the sentence "a process can be in one of four > scheduling classes" is not true, because we have three classes only. > > The change to ionice.c makes sense, but the "none" should be more > carefully described in the man page. Please, see below my suggestion. > > Karel This is obsoletet by http://git.kernel.org/?p=utils/util-linux-ng/util-linux-ng.git;a=commitdiff;h=9bc0e24612e709449e3ff6fea926dd2ae746dfca AFAICS. Sorry, i didn't have time to comment on your original patch. Yes, all the other docs say we have three classes only - i wasn't really sure how to handle that when i submitted the patch, because from a ionice users' perspective there are four classes. The change looks good - it now agrees with the other docs and it still includes all the info. There are some singular/plural issues in the change though. I would do -The processes that has not asked for io priority formally use "\fBnone\fP" as a -scheduling class, but the io scheduler will treat such processes as if they +A process that has not asked for an io priority formally uses "\fBnone\fP" as +scheduling class, but the io scheduler will treat such a process as if it Regarding the "Allow setting the none class" patch: I will resend it against the latest version of the man page in a few days. Jakob -- To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
