On Sun, Nov 30, 2008 at 23:46, Karel Zak <kzak@xxxxxxxxxx> wrote:
> On Sun, Nov 30, 2008 at 07:38:34PM +0000, James Youngman wrote:
>> On Sun, Nov 30, 2008 at 5:41 PM, Kay Sievers <kay.sievers@xxxxxxxx> wrote:
>> > Without libvolume_id, we may need to add something like this to
>> > your libblkid version to find the udev links. Alternatively we could
>
> The plan is to add this hex-encoding to libblkid.
Fine.
>> > link against libudev, but including the code may be the straight-forward
>> > and simpler solution.
>
> Why do you need this code in libudev?
It's used in udev for other stuff too, we need to translate pathes
with slashes, sanitize user-provided input in other cases too. The
code is in the lib, but not exported today.
> SYMLINK+="disk/by-uuid/$env{ID_FS_UUID_ENC}"
>
> It seems that everything what we need is to generate proper
> $ID_FS_UUID* by vol_id (or in future by blkid --low-probe). We also
> need to read the by-uuid/ directory in mount(8) (and maybe in HAL),
> so it makes sense to add/move this code to libblkid. Right?
>
>> Creating two, separately maintained, copies of the code is prone to
>> future maintenance problems.
>
> I'm not sure if we want to link fsck, mount, ... against libudev.
I wouldn't really like that too, that's why I sent this. :)
Kay
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
