-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Micah Cowan wrote: <snip> > -= what can be done =- > > From a Correctness POV, the right way to deal with this is to fix > script.c, not scriptreplay.c. The simple act of moving the newtime > calculation to below the read, rather than before it (and, perhaps, > calculating oldtime using gettimeofday, so we don't introduce a spurious > ~half-second delay) will have things working better than they ever did, > and result in a much more straightforward way to process the timing file > (i.e., the way scriptreplay does it now). > > From a Pragmatism POV, though, there's the fact that, if we simply > kludge scriptreplay.c to behave as the original did, then the timing > files from all versions of script, new and old, will work with the > current scriptreplay. If we fix script.c instead, then everyone has to > be careful not to mix versions of script. Does anyone authoritative have a comment on this? I'm happy with either solution, and will gladly write the code; I just need to know which one you want fixed: script or scriptreplay. - -- Micah J. Cowan Programmer, musician, typesetting enthusiast, gamer. GNU Maintainer: wget, screen, teseq http://micah.cowan.name/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIj5Gv7M8hyUobTrERAuzFAJ9foH9EOeBxcjv4KkqdP/R+J3xqVQCdFZ0K 6+FRVQIkgkxBK77fTjpNSuE= =akc8 -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
