Re: For mount man page: doc for new mount [fat] option (tz=UTC)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 Hi Joe,

On Sun, Jul 27, 2008 at 11:42:20PM -0600, Joe Peterson wrote:
> A patch I submitted to the Linux kernel was merged into the mainline 2

 yes, I see:

        commit b271e067c896ad4082b15e96077675d08db40625
        Author: Joe Peterson <joe@xxxxxxxxxxx>
        Date:   Fri Jul 25 01:46:47 2008 -0700

            fatfs: add UTC timestamp option


> +tz=UTC        -- Interpret timestamps as UTC rather than local time.

 why we need this (<key>=<value>) format of the option? The option
 does not support any other value than "UTC". The format is hardcoded
 in kernel:

         static match_table_t fat_tokens = {
        @@ -883,6 +891,7 @@ static match_table_t fat_tokens = {
            {Opt_obsolate, "cvf_options=%100s"},
            {Opt_obsolate, "posix"},
            {Opt_flush, "flush"},
        +	{Opt_tz_utc, "tz=UTC"},
            {Opt_err, NULL},
         };

 Shouldn't be better to use a simple option? For example

            {Opt_tz_utc, "utc"},

 it means without "tz=".

 [It would be nice to be in CC: for all lkml discussion about mount
 options :-)]

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux