Re: [PATCH][RESEND] ldattach(8) [v2]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 06, 2008 at 06:49:28PM +0100, Tilman Schmidt wrote:
> Add an ldattach(8) utility program similar to the one in OpenBSD.

 Good work. Applied, thanks.

 Please, next time use git-send-email rather than Mozilla. The git
 doesn't touch mail body.

> +#define dbg(format, arg...) \
> +	do { if (debug) fprintf(stderr , "%s:" format "\n" , progname , ## arg); } while (0)

 Isn't it more portable to use:

    fprintf(stderr , "%s:" format "\n" , progname , ##__VA_ARGS__);


On Fri, Mar 07, 2008 at 05:13:42AM -0500, Christoph Hellwig wrote:
> 
> Not that I have a whole lot of authority for util-linux, but this looks
> good to me.

 Thanks for review.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux