Hello Mike,
thank you very much for your comments. I wanted to mention these two
issues but then somehow forgot about it.
On Tue, Dec 11, 2007 at 05:54:11PM -0500, Mike Frysinger wrote:
> executing `pkg-config` is not friendly to cross-setups. you should use
> AC_PATH_TOOL to setup the PKG_CONFIG environment variable and then use that
> later on
I was asking myself why "pkg-config" is not enough, the cross-compile
case has not came to my mind.
A small question remains: why full path? wouldn't AC_CHECK_TOOL suffice?
In any case, this convinces me that using pkg.m4 is a good idea.
> > # These default values should work in most cases:
> > : ${BLKID_LIBS='-lblkid'}
> > : ${VOLUMEID_LIBS='-lvolume_id'}
>
> why only go half way ? i'd use pkg-config for everything.
I don't think it is needed, AFAIK, mere "-lblkid" suffices for
systems with GNU ld.so, as the rest is resolved by ld.so because of
.so dependencies.
Until the blkid.pc is fixed (s/Requires/&.private/), the pkg-config
version of BLKID_LIBS is even slightly worse than the fixed
"-lblkid". (The build won't fail, but the binaries will have
unneeded DT_NEEDED tags.)
IIRC, the Karel has said that the pkg-config description in blkid is
relatively new; with my patch, util-linux-ng build without
pkg-config, unless a static build is required.
Does this convince you?
Thanks again for review,
Stepan
-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
