Karel Zak <kzak@xxxxxxxxxx> writes: >> Move all locale/nls related includes to nls.h and make sure they are only >> pulled in when ENABLE_NLS. When !ENABLE_NLS, don't include any locale/nls >> related headers and stub out setlocale() as well. > > Maybe we can add --disable-locales and --disable-nls option will be > subset of --disable-locales. > > BTW, is there any real life example for this change? Building with -O0 for example The locale.h include in libintl.h is conditionnalized this way: #if defined __OPTIMIZE__ && !defined __cplusplus [...] # include <locale.h> mkfs tools didn't build out of the box with -O0, nls.h includes libintl.h, which does not include locale.h with this optimization level. I was just about to submit a similar patch :-) -- Olivier Blin - Mandriva - To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html