Re: [patch] fix swapon header creep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 13, 2007 at 05:52:55AM -0400, Mike Frysinger wrote:
> On Wednesday 13 June 2007, Karel Zak wrote:
> > On Wed, Jun 13, 2007 at 04:37:14AM -0400, Mike Frysinger wrote:
> > > On Wednesday 13 June 2007, Karel Zak wrote:
> > > > On Tue, Jun 12, 2007 at 11:25:24PM -0400, Mike Frysinger wrote:
> > > > > patch fixes this ... not that i can even guess why asm/page.h is
> > > > > needed in the first place since swapon doesnt use any of the PAGE_*
> > > > > defines ...
> > > >
> > > >  I think we needn't asm/page.h anymore.
> > >
> > > that works for me as well ;)
> >
> >  Well, you need to re-submit a new version of your patch ;-))
> 
> fooie !  glancing through swapon.c, looks like i'll just clean it up ...
> 
> this patch scrubs anything related to SWAPON_NEEDS_TWO_ARGS as this is only
> relevant for <linux-1.3.2 and i say it's about time we let it go.  i also
> cleaned up the system call fallback logic as the _syscall#() macros are the
> deprecated interface in favor of the real syscall() function.  asm/page.h gets
> the boot as nothing in swapon.c utilizes defines from it while unistd.h gets
> always included as defines/functions are used from it other than just
> swapon().
> 
> Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>

 Thanks, committed (but not at kernel.org yet).

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux