Re: [patch] fix swapon header creep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 13 June 2007, Karel Zak wrote:
> On Tue, Jun 12, 2007 at 11:25:24PM -0400, Mike Frysinger wrote:
> > not sure why asm/page.h and sys/swap.h header checks were added to
> > configure.ac and then swapon.c ignores the results of those tests, but
> > this
>
>  Commit: b34258064dd36e6b22b0ea8bf3ad4365cc078057
>
>  There was mount/swap.configure with page.h and Stepan has moved this test
>  to configure.ac.

what i meant was, the Stephan was obviously doing the right thing (moving mini 
hacks out of the subdir and into the toplevel configure.ac as a proper test), 
i just dont know why he didnt turn around and actually use the proper results 
from the tests in swapon.c but continued on with the old define checks

> > patch fixes this ... not that i can even guess why asm/page.h is needed
> > in the first place since swapon doesnt use any of the PAGE_* defines ...
>
>  I think we needn't asm/page.h anymore.

that works for me as well ;)
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux