On Fri, May 11, 2007 at 08:48:09PM +0200, Kay Sievers wrote:
> On 5/10/07, Kay Sievers <kay.sievers@xxxxxxxx> wrote:
> >On 5/10/07, Karel Zak <kzak@xxxxxxxxxx> wrote:
> >> Well, you can export the replace_untrusted_chars() function, but this
> >> is not solution, because
> >>
> >> replace_untrusted_chars("fooXbar") == replace_untrusted_chars("foo_bar)
> >>
> >> if the 'X' is a unsafe character.
> >>
> >> The concept is wrong, because you can't convert a "safe label" back
> >> to the "raw label". The correct solution is escape (hex, oct, ...)
> >> unsafe chars rather than remove it. So... /dev/disk/by-raw-label.
> >> Kay?
> >
> >Right, that sounds much nicer to encode it.
>
> Karel,
> how about using url-encoding style strings for the label-links? So the
> plain ascii text labels would still look the same, but slashes and
> other control chars are safely escaped.
>
> I could export that encoding-function from libvolume_id, and also let
> udev create these links in /dev/disk/by-label/. That way, a label:
> /home/foo/bar
> would create:
> /dev/disk/by-label/%2fhome%2ffoo%2fbar
> and the device could safely be looked up there with LABEL=.
>
> How does that sound?
Sounds good. Go ahead :-)
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
