On Tue, Mar 11, 2025 at 12:21:52PM +0100, Jonas Rebmann wrote:
> Hi Ahmad,
>
> Not so much. As mentioned in the cover, the imx8 boards routinely configure
> a larger array of pca9450 registers. As I didn't give the rest of that setup
> a closer look, I did not change the code.
>
> I have only tested this series on the phyboard segin imx93.
>
> Just like with the imx93 boards, after application of the driver patch, the
> { PCA9450_RESET_CTRL, 0xA1 } lines in lowlevel.c should no more have an
> effect (as no board currently uses nxp,wdog_b-warm-reset).
>
> Should I remove all { PCA9450_RESET_CTRL, 0xA1 } configuration in v2?
Better not. We have other PMIC register accesses in the lowlevel.c
anyway, so having one more doesn't hurt. The positive effect is that
these boards work better in case the PMIC driver is disabled.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
