Hi, On 30.10.24 18:50, Alexander Shiyan wrote: > Hello. > >>> This reverts commit d1fe68f1b010b83ddd3559ffbfcb70dca68b2563 >>> and ec3b8c646bdc8c2ea0a78923ccb745012eabc097 (as a fixup). >>> >>> The message "CONFIG_NAND_NEED_ECC_PLACEMENT_INTERLEAVED is disabled" >>> is always issued, regardless of the MTD ECC layout used, since it >>> is executed through "fallthrough" from the previous case statement. >>> >>> Additionally, if !IS_ENABLED(CONFIG_NAND_NEED_ECC_PLACEMENT_INTERLEAVED) >>> is triggered, the patch calls break, which disables the additional checks. > ... >> These config options were added to control barebox size. We need something >> here, so size conscious users can opt out. > > Well, I hope you understood from the description that it was not done > entirely correctly. Yes, but I think there should be a better way than doing a revert. Cheers, Ahmad > > Thanks! > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
