Re: [PATCH 1/7] spi: add rockchip spi controller support

[Alexander Shiyan <eagle.alexander923@xxxxxxxxx>]

Hello.

вт, 15 окт. 2024 г. в 14:21, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>:
>
> This adds support for the SPI controller found on many Rockchip SoCs.
> The driver is based on the corresponding Linux driver as of
> Linux-6.12-rc1.
...
> diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile
> index 68a8c4e675..f9aefdfe45 100644
> --- a/drivers/spi/Makefile
> +++ b/drivers/spi/Makefile
> @@ -17,3 +17,4 @@ obj-$(CONFIG_SPI_ZYNQ_QSPI) += zynq_qspi.o
>  obj-$(CONFIG_SPI_NXP_FLEXSPI) += spi-nxp-fspi.o
>  obj-$(CONFIG_DRIVER_SPI_STM32) += stm32_spi.o
>  obj-$(CONFIG_SPI_SIFIVE) += spi-sifive.o
> +obj-y += spi-rockchip.o

Why do you enable the driver without conditions?
Maybe you need a KConfig symbol here?