On Mon, Sep 30, 2024 at 08:35:54AM +0200, Ahmad Fatoum wrote: > On 27.09.24 12:37, Sascha Hauer wrote: > > This adds support for the Rockchip VOP2 video core found on the Rockchip > > SoCs RK3566, RK3568 and RK3588. The code is based on the Linux driver > > and has been heavily stripped down for barebox. Support for the cluster > > windows has been removed, also support for YUV modes has been dropped. > > > > Tested-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> # rk3566 HDMI > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > --- > > > +struct driver vop2_driver = { > > + .probe = vop2_bind, > > + .name = "rockchip-vop2", > > + .of_compatible = vop2_dt_match, > > +}; > > +device_platform_driver(vop2_driver); > > Unfortunately, this causes the VOP2 driver to hang my CPU on the first > MMIO access, unless I move it back to late_initcall level. > > I added *_ensure_probed for the Rockchip I/O domain device, but this > didn't help and I am not sure where exactly (device dependency? timing?) > the problem is. Any ideas? No idea, sorry. I switched back to late_platform_driver() while applying. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |